GitHub Issue #875: LuminexUpgradeCode.checkForMissingSummaryRows#989
Open
cnathe wants to merge 4 commits intorelease25.11-SNAPSHOTfrom
Open
GitHub Issue #875: LuminexUpgradeCode.checkForMissingSummaryRows#989cnathe wants to merge 4 commits intorelease25.11-SNAPSHOTfrom
cnathe wants to merge 4 commits intorelease25.11-SNAPSHOTfrom
Conversation
- java upgrade script for the Luminex case of missing summary background type rows for runs that have both summary and raw data
Contributor
Author
|
Step 1: from the admin console > sql scripts > upgrade code, select Luminex checkForMissingSummaryRows and invoke: Step 2: review log info / warnings to see list of affected / updated runs: Step 3: review audit logs inserted for rows affected: |
…d/analyteid/dataid/type combination
…fter the issue was deployed
…e SQLFragment updates for MSSQL compatibility
labkey-klum
reviewed
Mar 26, 2026
| filter.addCondition(FieldKey.fromParts("Type"), type); | ||
|
|
||
| // keep track of the set of wells for the given dataId/analyteId/type/standard combinations | ||
| record WellGroupKey(long dataId, int analyteId, String type, String standard) {} |
Contributor
There was a problem hiding this comment.
That's pretty neat, I didn't know records could be used as hash keys.
labkey-klum
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Related to #875 Luminex Multi-File Transform Import Skips First Data Row
For one of the Luminex clients, a set of the assay runs that are missing data rows for the multi-file input case includes rows where the run included both summary and raw data rows and just the summary data rows are missing. In the case of background type rows, these summary rows can be recalculated and inserted into the DB attached to the assay run (dataid, analyteid, type). This PR adds a Java upgrade script which will not be triggered via the regular SQL upgrade path but will instead of available for a site admin to manually run on the client's server.
Related Pull Requests
Changes